Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to non-deprecated calls #41

Closed
wants to merge 3 commits into from
Closed

Conversation

cdenneen
Copy link
Contributor

Utilize validate_legacy from stdlib

@pcfens
Copy link
Contributor

pcfens commented Mar 20, 2018

Would you rather do it this way or change the input types to types?

@cdenneen
Copy link
Contributor Author

cdenneen commented Mar 20, 2018 via email

@pcfens
Copy link
Contributor

pcfens commented Mar 20, 2018

Do you think you might have time to do that soon? If you do then I'll hold off on merging this. If you think it might be a bit then I'll go ahead and merge this so we'll have something and then we'll just see which of us gets to it first.

Thanks for bringing this one up.

@cdenneen
Copy link
Contributor Author

#42 opened... not sure which you would rather.
Had to fix few spec tests using String of 'true' rather than Boolean value.

@pcfens
Copy link
Contributor

pcfens commented Mar 21, 2018

I'm going to close this since #42 is merged now. Thanks again for all your help.

@pcfens pcfens closed this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants