Move OS specific data from params.pp into hiera #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
May 28, 2024
manifests/init.pp
Outdated
| # @param update_cmd | ||
| # Command to be used to update CA certificates. | ||
| # Default provided by Hiera for Archlinux, Debian, RedHat and Suse families. |
There was a problem hiding this comment.
Lists trend to age like milk… Maybe just say something like:
Suggested change
| # Default provided by Hiera for Archlinux, Debian, RedHat and Suse families. | |
| # Default provided by Hiera for supported Operating Systems. |
spec/defines/ca_spec.rb
Outdated
| @@ -256,83 +253,6 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'On Suse 11 based systems' do | |||
There was a problem hiding this comment.
Not sure why Suse 11 tests are removed. Are they duplicate of Suse 12 and so not relevant? Please tell us more in the commit message.
There was a problem hiding this comment.
Suse 11 was EOL in 2022 and support dropped in #97
There was a problem hiding this comment.
I have one finale thing to extract from #81 and that is to refactor this file to use 'on_supported_os'
I'll do this in a separate PR.
There was a problem hiding this comment.
I see that there's still some suse 10 an 11 code left in pp-files.
I'll remove this in a separate PR and then rebase this one.
kenyon
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.