rubocop: autocorrect

voxpupuli · Feb 24, 2024 · cb8d9bc · cb8d9bc
1 parent 57d3c39
commit cb8d9bc
Show file tree

Hide file tree

Showing 8 changed files with 171 additions and 74 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -0,0 +1,80 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2024-02-24 22:47:48 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 9
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'spec/defines/ca_spec.rb'
+
+# Offense count: 10
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/classes/ca_cert_spec.rb'
+    - 'spec/classes/params_spec.rb'
+    - 'spec/defines/ca_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: MaximumRangeSize.
+Lint/MissingCopEnableDirective:
+  Exclude:
+    - 'spec/classes/update_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+Naming/VariableNumber:
+  Exclude:
+    - 'spec/spec_helper_acceptance.rb'
+
+# Offense count: 2
+# Configuration parameters: Max.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/defines/ca_spec.rb'
+
+# Offense count: 9
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/defines/ca_spec.rb'
+
+# Offense count: 28
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 8
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupBody:
+  Exclude:
+    - 'spec/acceptance/ca_cert_ca_spec.rb'
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/defines/ca_spec.rb'
+
+# Offense count: 2
+RSpec/VoidExpect:
+  Exclude:
+    - 'spec/defines/ca_spec.rb'
+
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'spec/acceptance/ca_cert_ca_spec.rb'
+    - 'spec/acceptance/class_spec.rb'
+    - 'spec/classes/ca_cert_spec.rb'
+    - 'spec/classes/params_spec.rb'
+    - 'spec/classes/update_spec.rb'
+    - 'spec/defines/ca_spec.rb'
diff --git a/spec/acceptance/ca_cert_ca_spec.rb b/spec/acceptance/ca_cert_ca_spec.rb
@@ -14,48 +14,48 @@
 describe 'ca_cert::ca' do
   context 'with some normal usage' do
     let(:pp) do
-      <<-EOS
-        include ::ca_cert
+      <<~EOS
+                include ::ca_cert
 
-        ca_cert::ca { 'Globalsign_Org_Intermediate':
-          source => 'http://secure.globalsign.com/cacert/gsorganizationvalsha2g2r1.crt',
-        }
+                ca_cert::ca { 'Globalsign_Org_Intermediate':
+                  source => 'http://secure.globalsign.com/cacert/gsorganizationvalsha2g2r1.crt',
+                }
 
-        ca_cert::ca { 'InCommon':
-          ca_text => '-----BEGIN CERTIFICATE-----
-MIIEwzCCA6ugAwIBAgIQf3HB06ImsNKxE/PmgWdkPjANBgkqhkiG9w0BAQUFADBv
-MQswCQYDVQQGEwJTRTEUMBIGA1UEChMLQWRkVHJ1c3QgQUIxJjAkBgNVBAsTHUFk
-ZFRydXN0IEV4dGVybmFsIFRUUCBOZXR3b3JrMSIwIAYDVQQDExlBZGRUcnVzdCBF
-eHRlcm5hbCBDQSBSb290MB4XDTEwMTIwNzAwMDAwMFoXDTIwMDUzMDEwNDgzOFow
-UTELMAkGA1UEBhMCVVMxEjAQBgNVBAoTCUludGVybmV0MjERMA8GA1UECxMISW5D
-b21tb24xGzAZBgNVBAMTEkluQ29tbW9uIFNlcnZlciBDQTCCASIwDQYJKoZIhvcN
-AQEBBQADggEPADCCAQoCggEBAJd8x8j+s+kgaqOkT46ONFYGs3psqhCbSGErNpBp
-4zQKR6e7e96qavvrgpWPyh1/r3WmqEzaIGdhGg2GwcrBh6+sTuTeYhsvnbGYr8YB
-+xdw26wUWexvPzN/ppgL5OI4r/V/hW0OdASd9ieGx5uP53EqCPQDAkBjJH1AV49U
-4FR+thNIYfHezg69tvpNmLLZDY15puCqzQyRmqXfq3O7yhR4XEcpocrFup/H2mD3
-/+d/8tnaoS0PSRan0wCSz4pH2U341ZVm03T5gGMAT0yEFh+z9SQfoU7e6JXWsgsJ
-iyxrx1wvjGPJmctSsWJ7cwFif2Ns2Gig7mqojR8p89AYrK0CAwEAAaOCAXcwggFz
-MB8GA1UdIwQYMBaAFK29mHo0tCb3+sQmVO8DveAky1QaMB0GA1UdDgQWBBRIT1r6
-L0qaXuBQ82t7VaXe9b40XTAOBgNVHQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB
-/wIBADARBgNVHSAECjAIMAYGBFUdIAAwRAYDVR0fBD0wOzA5oDegNYYzaHR0cDov
-L2NybC51c2VydHJ1c3QuY29tL0FkZFRydXN0RXh0ZXJuYWxDQVJvb3QuY3JsMIGz
-BggrBgEFBQcBAQSBpjCBozA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1
-c3QuY29tL0FkZFRydXN0RXh0ZXJuYWxDQVJvb3QucDdjMDkGCCsGAQUFBzAChi1o
-dHRwOi8vY3J0LnVzZXJ0cnVzdC5jb20vQWRkVHJ1c3RVVE5TR0NDQS5jcnQwJQYI
-KwYBBQUHMAGGGWh0dHA6Ly9vY3NwLnVzZXJ0cnVzdC5jb20wDQYJKoZIhvcNAQEF
-BQADggEBAJNmIYB0RYVLwqvOMrAp/t3f1iRbvwNqb1A+DhuzDYijW+7EpBI7Vu8G
-f89/IZVWO0Ex/uGqk9KV85UNPEerylwmrT7x+Yw0bhG+9GfjAkn5pnx7ZCXdF0by
-UOPjCiE6SSTNxoRlaGdosEUtR5nNnKuGKRFy3NacNkN089SXnlag/l9AWNLV1358
-xY4asgRckmYOha0uBs7Io9jrFCeR3s8XMIFTtmYSrTfk9e+WXCAONumsYn0ZgYr1
-kGGmSavOPN/mymTugmU5RZUWukEGAJi6DFZh5MbGhgHPZqkiKQLWPc/EKo2Z3vsJ
-FJ4O0dXG14HdrSSrrAcF4h1ow3BmX9M=
------END CERTIFICATE-----',
-        }
+                ca_cert::ca { 'InCommon':
+                  ca_text => '-----BEGIN CERTIFICATE-----
+        MIIEwzCCA6ugAwIBAgIQf3HB06ImsNKxE/PmgWdkPjANBgkqhkiG9w0BAQUFADBv
+        MQswCQYDVQQGEwJTRTEUMBIGA1UEChMLQWRkVHJ1c3QgQUIxJjAkBgNVBAsTHUFk
+        ZFRydXN0IEV4dGVybmFsIFRUUCBOZXR3b3JrMSIwIAYDVQQDExlBZGRUcnVzdCBF
+        eHRlcm5hbCBDQSBSb290MB4XDTEwMTIwNzAwMDAwMFoXDTIwMDUzMDEwNDgzOFow
+        UTELMAkGA1UEBhMCVVMxEjAQBgNVBAoTCUludGVybmV0MjERMA8GA1UECxMISW5D
+        b21tb24xGzAZBgNVBAMTEkluQ29tbW9uIFNlcnZlciBDQTCCASIwDQYJKoZIhvcN
+        AQEBBQADggEPADCCAQoCggEBAJd8x8j+s+kgaqOkT46ONFYGs3psqhCbSGErNpBp
+        4zQKR6e7e96qavvrgpWPyh1/r3WmqEzaIGdhGg2GwcrBh6+sTuTeYhsvnbGYr8YB
+        +xdw26wUWexvPzN/ppgL5OI4r/V/hW0OdASd9ieGx5uP53EqCPQDAkBjJH1AV49U
+        4FR+thNIYfHezg69tvpNmLLZDY15puCqzQyRmqXfq3O7yhR4XEcpocrFup/H2mD3
+        /+d/8tnaoS0PSRan0wCSz4pH2U341ZVm03T5gGMAT0yEFh+z9SQfoU7e6JXWsgsJ
+        iyxrx1wvjGPJmctSsWJ7cwFif2Ns2Gig7mqojR8p89AYrK0CAwEAAaOCAXcwggFz
+        MB8GA1UdIwQYMBaAFK29mHo0tCb3+sQmVO8DveAky1QaMB0GA1UdDgQWBBRIT1r6
+        L0qaXuBQ82t7VaXe9b40XTAOBgNVHQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB
+        /wIBADARBgNVHSAECjAIMAYGBFUdIAAwRAYDVR0fBD0wOzA5oDegNYYzaHR0cDov
+        L2NybC51c2VydHJ1c3QuY29tL0FkZFRydXN0RXh0ZXJuYWxDQVJvb3QuY3JsMIGz
+        BggrBgEFBQcBAQSBpjCBozA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1
+        c3QuY29tL0FkZFRydXN0RXh0ZXJuYWxDQVJvb3QucDdjMDkGCCsGAQUFBzAChi1o
+        dHRwOi8vY3J0LnVzZXJ0cnVzdC5jb20vQWRkVHJ1c3RVVE5TR0NDQS5jcnQwJQYI
+        KwYBBQUHMAGGGWh0dHA6Ly9vY3NwLnVzZXJ0cnVzdC5jb20wDQYJKoZIhvcNAQEF
+        BQADggEBAJNmIYB0RYVLwqvOMrAp/t3f1iRbvwNqb1A+DhuzDYijW+7EpBI7Vu8G
+        f89/IZVWO0Ex/uGqk9KV85UNPEerylwmrT7x+Yw0bhG+9GfjAkn5pnx7ZCXdF0by
+        UOPjCiE6SSTNxoRlaGdosEUtR5nNnKuGKRFy3NacNkN089SXnlag/l9AWNLV1358
+        xY4asgRckmYOha0uBs7Io9jrFCeR3s8XMIFTtmYSrTfk9e+WXCAONumsYn0ZgYr1
+        kGGmSavOPN/mymTugmU5RZUWukEGAJi6DFZh5MbGhgHPZqkiKQLWPc/EKo2Z3vsJ
+        FJ4O0dXG14HdrSSrrAcF4h1ow3BmX9M=
+        -----END CERTIFICATE-----',
+                }
 
-        ca_cert::ca { 'CACert':
-          source => 'http://www.cacert.org/certs/root.crt',
-          ensure => 'distrusted',
-        }
+                ca_cert::ca { 'CACert':
+                  source => 'http://www.cacert.org/certs/root.crt',
+                  ensure => 'distrusted',
+                }
       EOS
     end
 

diff --git a/spec/classes/ca_cert_spec.rb b/spec/classes/ca_cert_spec.rb
@@ -27,7 +27,7 @@
         'ensure' => 'directory',
         'path'   => '/usr/local/share/ca-certificates',
         'group'  => 'staff',
-        'purge'  => 'false',
+        'purge'  => 'false'
       )
     }
 
@@ -43,11 +43,12 @@
           'ensure' => 'directory',
           'path'   => '/usr/local/share/ca-certificates',
           'group'  => 'staff',
-          'purge'  => 'true',
+          'purge'  => 'true'
         )
       }
     end
   end
+
   context 'on a RedHat based OS' do
     let :facts do
       {
@@ -71,7 +72,7 @@
         'ensure' => 'directory',
         'path'   => '/etc/pki/ca-trust/source/anchors',
         'group'  => 'root',
-        'purge'  => 'false',
+        'purge'  => 'false'
       )
     }
 
@@ -87,13 +88,13 @@
           'ensure' => 'directory',
           'path'   => '/etc/pki/ca-trust/source/anchors',
           'group'  => 'root',
-          'purge'  => 'true',
+          'purge'  => 'true'
         )
       }
     end
   end
 
-  ['10', '11'].each do |osmajrel|
+  %w[10 11].each do |osmajrel|
     context "on a Suse #{osmajrel} based OS" do
       let :facts do
         {
@@ -115,7 +116,7 @@
           'ensure' => 'directory',
           'path'   => '/etc/ssl/certs',
           'group'  => 'root',
-          'purge'  => 'false',
+          'purge'  => 'false'
         )
       }
 
@@ -131,7 +132,7 @@
             'ensure' => 'directory',
             'path'   => '/etc/ssl/certs',
             'group'  => 'root',
-            'purge'  => 'true',
+            'purge'  => 'true'
           )
         }
       end
@@ -159,7 +160,7 @@
         'ensure' => 'directory',
         'path'   => '/etc/pki/trust/anchors',
         'group'  => 'root',
-        'purge'  => 'false',
+        'purge'  => 'false'
       )
     }
 
@@ -175,11 +176,12 @@
           'ensure' => 'directory',
           'path'   => '/etc/pki/trust/anchors',
           'group'  => 'root',
-          'purge'  => 'true',
+          'purge'  => 'true'
         )
       }
     end
   end
+
   context 'on an unsupported operating system' do
     let :facts do
       {

diff --git a/spec/classes/params_spec.rb b/spec/classes/params_spec.rb
@@ -6,9 +6,9 @@
     it { is_expected.to contain_class('ca_cert::params') }
   end
 
-  [
-    'Debian',
-    'RedHat',
+  %w[
+    Debian
+    RedHat
   ].each do |osfamily|
     let :facts do
       {
@@ -27,7 +27,7 @@
     end
   end
 
-  ['10', '11', '12'].each do |osmajrel|
+  %w[10 11 12].each do |osmajrel|
     context "On a Suse #{osmajrel} Operating System" do
       let :facts do
         {

diff --git a/spec/classes/update_spec.rb b/spec/classes/update_spec.rb
@@ -14,10 +14,11 @@
       case facts[:os]['family']
       when 'Debian'
         it { is_expected.not_to contain_exec('enable_ca_trust') }
+
         it {
           is_expected.to contain_exec('ca_cert_update').with(
             command: 'update-ca-certificates',
-            refreshonly: true,
+            refreshonly: true
           )
         }
       when 'RedHat'
@@ -39,24 +40,25 @@
         it {
           is_expected.to contain_exec('ca_cert_update').with(
             command: 'update-ca-trust extract',
-            refreshonly: true,
+            refreshonly: true
           )
         }
       when 'Suse'
         it { is_expected.not_to contain_exec('enable_ca_trust') }
+
         case facts[:os]['release']['major']
         when '10', '11'
           it {
             is_expected.to contain_exec('ca_cert_update').with(
               command: 'c_rehash',
-              refreshonly: true,
+              refreshonly: true
             )
           }
         when '12', '13', '42'
           it {
             is_expected.to contain_exec('ca_cert_update').with(
               command: 'update-ca-certificates',
-              refreshonly: true,
+              refreshonly: true
             )
           }
         end