handle paths/urls with special characters (#24)

voxpupuli · Jan 27, 2017 · 3bdc414 · 3bdc414
1 parent 092d945
commit 3bdc414
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/manifests/ca.pp b/manifests/ca.pp
@@ -100,7 +100,7 @@
           }
           exec { "get_${resource_name}":
             command =>
-              "wget ${verify_https} -O ${ca_cert} ${source} 2> /dev/null",
+              "wget ${verify_https} -O '${ca_cert}' '${source}' 2> /dev/null",
             path    => ['/usr/bin', '/bin'],
             creates => $ca_cert,
             notify  => Exec['ca_cert_update'],

diff --git a/spec/defines/ca_spec.rb b/spec/defines/ca_spec.rb
@@ -120,7 +120,7 @@
         end
         it { is_expected.to contain_exec("get_Globalsign_Org_Intermediate.crt").with(
             'creates' => DEBIAN_CA_FILE,
-            'command' => "wget  -O #{DEBIAN_CA_FILE} #{HTTP_URL} 2> /dev/null",
+            'command' => "wget  -O '#{DEBIAN_CA_FILE}' '#{HTTP_URL}' 2> /dev/null",
           )
         }
         it { is_expected.not_to contain_file(DEBIAN_CA_FILE) }
@@ -175,7 +175,7 @@
 
         it { is_expected.to contain_exec("get_Globalsign_Org_Intermediate.crt").with(
             'creates' => REDHAT_CA_FILE,
-            'command' => "wget  -O #{REDHAT_CA_FILE} #{HTTP_URL} 2> /dev/null",
+            'command' => "wget  -O '#{REDHAT_CA_FILE}' '#{HTTP_URL}' 2> /dev/null",
           ) }
         it { is_expected.not_to contain_file(REDHAT_CA_FILE) }
       end
@@ -211,7 +211,7 @@
         end
         it { is_expected.to contain_exec("get_Globalsign_Org_Intermediate.crt").with(
           'creates' => DISTRUSTED_REDHAT_CA_FILE,
-          'command' => "wget  -O #{DISTRUSTED_REDHAT_CA_FILE} #{HTTP_URL} 2> /dev/null",
+          'command' => "wget  -O '#{DISTRUSTED_REDHAT_CA_FILE}' '#{HTTP_URL}' 2> /dev/null",
         )}
       end
     end
@@ -236,7 +236,7 @@
 
         it { is_expected.to contain_exec("get_Globalsign_Org_Intermediate.pem").with(
             'creates' => SUSE_11_CA_FILE,
-            'command' => "wget  -O #{SUSE_11_CA_FILE} #{SUSE_11_HTTP_URL} 2> /dev/null",
+            'command' => "wget  -O '#{SUSE_11_CA_FILE}' '#{SUSE_11_HTTP_URL}' 2> /dev/null",
           ) }
         it { is_expected.not_to contain_file(SUSE_11_CA_FILE) }
       end
@@ -300,7 +300,7 @@
 
         it { is_expected.to contain_exec("get_Globalsign_Org_Intermediate.crt").with(
             'creates' => SUSE_12_CA_FILE,
-            'command' => "wget  -O #{SUSE_12_CA_FILE} #{HTTP_URL} 2> /dev/null",
+            'command' => "wget  -O '#{SUSE_12_CA_FILE}' '#{HTTP_URL}' 2> /dev/null",
           ) }
         it { is_expected.not_to contain_file(SUSE_12_CA_FILE) }
       end
@@ -338,7 +338,7 @@
         end
         it { is_expected.to contain_exec("get_Globalsign_Org_Intermediate.crt").with(
           'creates' => DISTRUSTED_SUSE_12_CA_FILE,
-          'command' => "wget  -O #{DISTRUSTED_SUSE_12_CA_FILE} #{HTTP_URL} 2> /dev/null",
+          'command' => "wget  -O '#{DISTRUSTED_SUSE_12_CA_FILE}' '#{HTTP_URL}' 2> /dev/null",
         )}
       end
     end