Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on beaker-hostgenerator for docker nodesets #118

Merged
merged 1 commit into from
May 13, 2018

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Apr 10, 2018

Will need a change in modulesync, but this should be a good preparation for when we move to use PDK more and more.

.travis.yml Outdated
@@ -28,25 +28,25 @@ matrix:
- rvm: 2.4.3
Copy link
Member

@dhollinger dhollinger Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is managed by modulesync. Probably should place the changes into the .sync.yml or the config_defaults.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to make these manual changes until those are merged into modulesync, simply because a modulesync to autofs will revert these changes until that modulesync PR is merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. This PR was my proof of concept to see if tests would pass on Travis. I'm preparing a bunch of PRs to rewrite all modules to use it.

@@ -52,6 +52,7 @@ group :system_tests do
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

@ekohl ekohl force-pushed the use-beaker-hostgenerator branch from 7285636 to 8681972 Compare May 13, 2018 11:42
@bastelfreak bastelfreak changed the title Use beaker-hostgenerator Rely on beaker-hostgenerator for docker nodesets May 13, 2018
@bastelfreak
Copy link
Member

@dhollinger can you approve it please?

@ekohl
Copy link
Member Author

ekohl commented May 13, 2018

Note the msync PR has been merged so this is now mostly a modulesync.

@ekohl ekohl merged commit 8681972 into voxpupuli:master May 13, 2018
@ekohl ekohl deleted the use-beaker-hostgenerator branch May 13, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants