-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on beaker-hostgenerator for docker nodesets #118
Conversation
ae3f018
to
7285636
Compare
.travis.yml
Outdated
@@ -28,25 +28,25 @@ matrix: | |||
- rvm: 2.4.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is managed by modulesync. Probably should place the changes into the .sync.yml or the config_defaults.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on voxpupuli/modulesync_config#453
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to make these manual changes until those are merged into modulesync, simply because a modulesync to autofs
will revert these changes until that modulesync PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. This PR was my proof of concept to see if tests would pass on Travis. I'm preparing a bunch of PRs to rewrite all modules to use it.
@@ -52,6 +52,7 @@ group :system_tests do | |||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
7285636
to
8681972
Compare
@dhollinger can you approve it please? |
Note the msync PR has been merged so this is now mostly a modulesync. |
Will need a change in modulesync, but this should be a good preparation for when we move to use PDK more and more.