-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absent GRUB_CMDLINE_LINUX_DEFAULT can result in duplicated kernel parameters. #38
Comments
@trevor-vaughan I see you code that part in https://github.com/hercules-team/augeasproviders_grub/blob/master/lib/puppet/provider/kernel_parameter/grub2.rb#L88-L108, what's your take on it? |
Interesting. This may be a RHEL quirk that I ended up testing around. @sandynomad What OS are you working against? |
The behaviour reported was on CentOS 7.5. |
@trevor-vaughan were you able to reproduce? |
trevor-vaughan
added a commit
to trevor-vaughan/augeasproviders_grub
that referenced
this issue
Mar 18, 2020
* Adds BLS support which should fix issues on EL8 and Fedora 30 * Fixed the issue with duplicating kernel options while debugging * Updates both non-EFI and EFI paths Closes voxpupuli#49 Closes voxpupuli#38 Closes voxpupuli#37
raphink
pushed a commit
that referenced
this issue
Mar 23, 2020
* Add BLS support to grub_menuentry * Adds BLS support which should fix issues on EL8 and Fedora 30 * Fixed the issue with duplicating kernel options while debugging * Updates both non-EFI and EFI paths Closes #49 Closes #38 Closes #37 * Work around provider boolean issue Also fixed a couple of minor issues with pre-populating provider data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using grub2 the initial state in /etc/default/grub includes:
GRUB_CMDLINE_LINUX populated
GRUB_CMDLINE_LINUX_DEFAULT absent
Used:
results in GRUB_CMDLINE_LINUX_DEFAULT being copied from GRUB_CMDLINE_LINUX and then massaged by the lens.
The resultant kernel boot line includes duplicate entries. According to the grub2 manual (https://www.gnu.org/software/grub/manual/grub/grub.html):
‘GRUB_CMDLINE_LINUX_DEFAULT’
Desired behaviour is for GRUB_CMDLINE_LINUX_DEFAULT to not being populated from GRUB_CMDLINE_LINUX as they maybe concatenated when generating the grub.conf
The text was updated successfully, but these errors were encountered: