Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absent GRUB_CMDLINE_LINUX_DEFAULT can result in duplicated kernel parameters. #38

Closed
sandynomad opened this issue Aug 29, 2018 · 4 comments · Fixed by #50
Closed

Absent GRUB_CMDLINE_LINUX_DEFAULT can result in duplicated kernel parameters. #38

sandynomad opened this issue Aug 29, 2018 · 4 comments · Fixed by #50

Comments

@sandynomad
Copy link

When using grub2 the initial state in /etc/default/grub includes:

GRUB_CMDLINE_LINUX populated
GRUB_CMDLINE_LINUX_DEFAULT absent

Used:

kernel_parameter { "pci=nomsi,noaer":
    ensure   => present,
    bootmode => "normal",
}

results in GRUB_CMDLINE_LINUX_DEFAULT being copied from GRUB_CMDLINE_LINUX and then massaged by the lens.

The resultant kernel boot line includes duplicate entries. According to the grub2 manual (https://www.gnu.org/software/grub/manual/grub/grub.html):

‘GRUB_CMDLINE_LINUX_DEFAULT’

    Unless ‘GRUB_DISABLE_RECOVERY’ is set to ‘true’, two menu entries will be
    generated for each Linux kernel: one default entry and one entry for recovery
    mode. This option lists command-line arguments to add only to the default
    menu entry, after those listed in ‘GRUB_CMDLINE_LINUX’.

Desired behaviour is for GRUB_CMDLINE_LINUX_DEFAULT to not being populated from GRUB_CMDLINE_LINUX as they maybe concatenated when generating the grub.conf

@raphink
Copy link
Member

raphink commented Aug 31, 2018

@trevor-vaughan
Copy link
Contributor

Interesting. This may be a RHEL quirk that I ended up testing around. @sandynomad What OS are you working against?

@sandynomad
Copy link
Author

The behaviour reported was on CentOS 7.5.

@raphink
Copy link
Member

raphink commented Oct 18, 2018

@trevor-vaughan were you able to reproduce?

trevor-vaughan added a commit to trevor-vaughan/augeasproviders_grub that referenced this issue Mar 18, 2020
* Adds BLS support which should fix issues on EL8 and Fedora 30
* Fixed the issue with duplicating kernel options while debugging
* Updates both non-EFI and EFI paths

Closes voxpupuli#49
Closes voxpupuli#38
Closes voxpupuli#37
raphink pushed a commit that referenced this issue Mar 23, 2020
* Add BLS support to grub_menuentry

* Adds BLS support which should fix issues on EL8 and Fedora 30
* Fixed the issue with duplicating kernel options while debugging
* Updates both non-EFI and EFI paths

Closes #49
Closes #38
Closes #37

* Work around provider boolean issue

Also fixed a couple of minor issues with pre-populating provider data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants