ruby provider: ensure cleanup happens #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 29, 2022
pillarsdotnet
force-pushed
the
328_cleanup_fix
branch
from
7b3e6f5 to
1de7888
Compare
pillarsdotnet
force-pushed
the
328_cleanup_fix
branch
from
1de7888 to
207e6a6
Compare
|
Hi @pillarsdotnet, thanks for the PR. can you please rebase against our latest master branch? |
pillarsdotnet
force-pushed
the
328_cleanup_fix
branch
from
207e6a6 to
3331ced
Compare
|
Rebased. |
|
@bastelfreak -- Would you please review? |
kenyon
force-pushed
the
328_cleanup_fix
branch
from
3331ced to
752a23b
Compare
kenyon
changed the title
|
@kenyon -- Thanks for fixes. |
kenyon
approved these changes
Dec 8, 2022
pillarsdotnet
force-pushed
the
328_cleanup_fix
branch
from
752a23b to
7571f6f
Compare
smortex
approved these changes
Apr 13, 2023
| raise(Puppet::Error, "Download file checksum mismatch (expected: #{checksum} actual: #{actual_checksum})") | ||
| end | ||
| end | ||
|
|
||
| move_file_in_place(temppath, archive_filepath) | ||
| ensure | ||
| FileUtils.rm_f(temppath) if File.exist?(temppath) |
There was a problem hiding this comment.
Technically you can rm_f a file that does not exist (because force is only about ignoring errors). Checking for existence does not hurt though, so I am fine with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Ensures that tempfile used for downloading gets deleted.
Ensures that the
cleanupparam is honored.This Pull Request (PR) fixes the following issues
Fixes #328