Run rubocop checks in matrix build #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `bundle exec rake rubocop`. This requires we install voxpupuli-test to get the rubocop dependencies.
traylenator
force-pushed
the
rerubocop
branch
from
8f10f9c
to
8b544b1
Compare
ekohl
reviewed
Dec 8, 2020
|
Will save a lot of docker images for sure. |
|
Btw, I opened puppetlabs/puppetlabs_spec_helper#327 which would also make it easy to run all pre-release checks during the validation. I also started a PR to voxpupuli-test, but then first wanted to complete voxpupuli/voxpupuli-test#37. Then the actual unit tests can be updated to run |
ekohl
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
bundle exec rake rubocop.This requires we install voxpupuli-test to get the rubocop
dependencies.