Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-122 Sync files that do not conform to *.erb #136

Closed
wants to merge 1 commit into from

Conversation

tphoney
Copy link

@tphoney tphoney commented Dec 1, 2017

No description provided.

@tphoney
Copy link
Author

tphoney commented Dec 1, 2017

This will resolve #122

@tphoney
Copy link
Author

tphoney commented Dec 1, 2017

@DavidS can you have a look

@ekohl
Copy link
Member

ekohl commented Dec 1, 2017

If you support both, would it make sense to only consider files with..erb extensions templates?

@DavidS
Copy link
Contributor

DavidS commented Dec 4, 2017

@ekohl that was the goal of my original change. Between push-back from others against that, and this bug here, we're not there yet.

@tphoney tphoney force-pushed the issues_122 branch 2 times, most recently from b89f631 to a3bce76 Compare December 4, 2017 14:55
@tphoney
Copy link
Author

tphoney commented Dec 4, 2017

@ekohl @DavidS does this go any further to address your concerns.

@ekohl
Copy link
Member

ekohl commented Dec 5, 2017

I wonder if this should directly implement the non-templated part. I'm afraid the partial implementation might cause confusion.

@alexjfisher
Copy link
Member

@ghoneycutt I’ve noticed you’ve approved this PR, but since it’s been a year, I’d like to get feedback from @ekohl and @tphoney before merging.

@tphoney tphoney closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants