Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERB suffix handling #114

Merged
merged 3 commits into from
Apr 28, 2017
Merged

ERB suffix handling #114

merged 3 commits into from
Apr 28, 2017

Commits on Apr 21, 2017

  1. rubocop:auto_correct

    DavidS committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    a715b78 View commit details
    Browse the repository at this point in the history
  2. Disable Style/IndentHeredoc

    Fixing those complaints would require using an external library.
    DavidS committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    02f88d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2017

  1. Never use .erb in the config, prefer it in filenames

    #93 changed modulesync to allow for .erb suffixed templates. In many cases
    this is useful to avoid the template being interpreted as the real thing
    by other tooling, like e.g. a `.gitattributes` file.
    
    As discovered around #113, the original fix was not complete, and e.g.
    failed when being combined with `:global` sections. This commit now moves
    more towards always using `.erb` suffixes on template's names, and - for
    readabilitie's sake - only look for un-adorned keys in the config files.
    
    Closes #113
    DavidS committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    ba191b0 View commit details
    Browse the repository at this point in the history