dev deps: Add strict version contraints & CI: build gem with strict mode & CI: Use Ruby 3.3 for releases #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Aug 19, 2024
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.1' | ||
| ruby-version: '3.3' |
There was a problem hiding this comment.
In another place I've been lazy and just used Ruby 3. Is that something we want here as well?
Suggested change
| ruby-version: '3.3' | |
| ruby-version: '3' |
There was a problem hiding this comment.
I'm not sure. I don't know under which conditions they will bump that version. I only bump the version in the release action when we've the same version in a test and it passes.
This raises the following error: ``` WARNING: You have specified the uri: https://github.com/voxpupuli/json-schema/ for all of the following keys: homepage_uri source_code_uri Only the first one will be shown on rubygems.org ```
TheMeier
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also contains #524