Switch to latest voxpupuli-rubocop

[bastelfreak]

Both ruby version are EoL. We already merged a breaking change to master, so I think it's good to drop those old ruby versions.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.58%. Comparing base (4aed27d) to head (a75665f).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
+ Coverage   90.08%   90.58%   +0.49%     
==========================================
  Files          76       76              
  Lines        1584     1572      -12     
==========================================
- Hits         1427     1424       -3     
+ Misses        157      148       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekohl]

metadata-json-lint pulls this in, so it can end up being painful for a lot of users. IIRC bundler in Ruby 2.5 isn't able to deal well with the required ruby version. Take that into consideration.

[bastelfreak]

@ekohl metadata-json-lint uses json-schema '>= 2.8', '< 4.0'. The next major release will be 4.0 so metadata-json-lint would not automatically pull it in. I suggest we bump Ruby here and when we bump it in metadata-json-lint to 2.7 we can pull in metadata-json-lint 4.x.

[ekohl]

My concern is that we will want to update https://github.com/voxpupuli/metadata-json-lint/blob/e089948daf5f18db6a873f6da4d661858905968b/metadata-json-lint.gemspec#L20 but if we make it < 5 then Bundler on Ruby 2.5 probably won't be able to resolve it (see what happened recently with Bundler). That implicitly breaks Puppet 6.

IMHO 👎 on dropping it in this gem unless we start using Puppet 2.7 features or Puppet 6 is really dead and buried.

[bastelfreak]

We now removed Ruby 2.6 and older in another PR. This one just updates rubocop. I left a bit of stuff in the todo file, otherwise the PR would have been too huge. I will clean that up in a followup PR.