Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'ARG UBUNTU_CODENAME' to final image build so that Podman correctly interprets PUPPET_DEB environment variable. #59

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

bschonec
Copy link
Contributor

@bschonec bschonec commented Apr 1, 2024

This change fixes build failure when using Podman to build the Docker image.

Fixes: #58

@rwaffen
Copy link
Member

rwaffen commented Apr 2, 2024

@bschonec may you please sign your commit?

@bschonec
Copy link
Contributor Author

bschonec commented Apr 2, 2024

@rwaffen, I'll be happy to but I am unfamiliar with the process. I'll search around for a HOWTO and sign as soon as I figure it out.

@bschonec
Copy link
Contributor Author

bschonec commented Apr 2, 2024

It still says, "Merging is blocked", but it refers to a "base branch." Is there something I still have to do?

@bastelfreak
Copy link
Member

@bschonec github says:

The email in this signature doesn’t match the committer email. GPG key ID: 20917A2F60787D20

…ly interprets PUPPET_DEB environment variable.
@bschonec
Copy link
Contributor Author

bschonec commented Apr 2, 2024

I think I got it fixed....

@bastelfreak bastelfreak added the bug Something isn't working label Apr 2, 2024
@bastelfreak bastelfreak merged commit 12186a5 into voxpupuli:main Apr 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docker image doesn't build correctly when using Podman
3 participants