Arch Linux: install net-tools and openssh #1722
Conversation
Both packages are required. net-tools provides netstat
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 82 82
Lines 4863 4863
=======================================
Hits 3630 3630
Misses 1233 1233
Continue to review full report at Codecov.
|
|
tested this on voxpupuli/puppet-nginx#1492 |
There was a problem hiding this comment.
I'm not strictly opposed to this, but I'd like to rant about something.
Right now these are only installed using SSH so installing SSH over SSH doesn't make sense. beaker-docker is in a weird state that it mostly duplicates this, but Arch reuses it. In #1718 I started an effort to make this easier to reuse. That's where I'd like to end up.
With that in mind, 👍
| @@ -17,7 +17,7 @@ module HostPrebuiltSteps | |||
| UNIX_PACKAGES = ['curl', 'ntpdate'] | |||
| FREEBSD_PACKAGES = ['curl', 'perl5|perl'] | |||
| OPENBSD_PACKAGES = ['curl'] | |||
| ARCHLINUX_PACKAGES = ['curl', 'ntp'] | |||
| ARCHLINUX_PACKAGES = ['curl', 'ntp', 'net-tools', 'openssh'] | |||
There was a problem hiding this comment.
Btw, normally net-tools is only installed via beaker-hostgenerator (see https://github.com/voxpupuli/beaker-hostgenerator/blob/master/lib/beaker-hostgenerator/data.rb). Beaker itself doesn't need net-tools and I already explained why openssh here doesn't make a lot of sense.
Both packages are required. net-tools provides netstat