-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure db connection for unpickled Dataset #4561
Conversation
WalkthroughA call to Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- fiftyone/core/odm/document.py (1 hunks)
Additional comments not posted (1)
fiftyone/core/odm/document.py (1)
592-593
: LGTM! Ensures database connection before reloading.The addition of
ensure_connection()
ensures that a database connection is established before reloading the document, preventing potentialConnectionFailure
errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes are proposed in this pull request?
Actual customer issue was due to using a parallel processing engine that basically created a
Dataset
object by deserializing, thereby bypassing any calls that make the DB connection inDataset.__init__()
.So just like how we call
ensure_connection()
beforeDocument._save()
it should also be fine to call it before anyreload()
of aDocument
. If we already have a connection this is a no-op.How is this patch tested? If it is not, please explain why.
Easiest way to show the issue.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit