Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #3686 #3690

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fixing #3686 #3690

merged 1 commit into from
Oct 19, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Oct 19, 2023

Resolves #3686

This was an unintentional regression of some (supposed) error checking introduced in #3517.

The example code from here now works again:
https://docs.voxel51.com/user_guide/model_zoo/models.html#dinov2-vits14-torch

import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset(
    "coco-2017",
    split="validation",
    dataset_name=fo.get_default_dataset_name(),
    max_samples=50,
    shuffle=True,
)

model = foz.load_zoo_model("dinov2-vits14-torch")

embeddings = dataset.compute_embeddings(model)

@brimoor brimoor added the bug Bug fixes label Oct 19, 2023
@brimoor brimoor requested a review from swheaton October 19, 2023 01:53
@brimoor brimoor self-assigned this Oct 19, 2023
@brimoor brimoor changed the base branch from develop to release/v0.22.2 October 19, 2023 01:53
Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, didnt realize it was that simple 😃

@brimoor brimoor merged commit 14e1ccb into release/v0.22.2 Oct 19, 2023
@brimoor brimoor deleted the iss-3686 branch October 19, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error when downloading dinov2_* zoo models
2 participants