Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pw #3411

Merged
merged 3 commits into from
Aug 14, 2023
Merged

upgrade pw #3411

merged 3 commits into from
Aug 14, 2023

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented Aug 14, 2023

What changes are proposed in this pull request?

  • Upgrade Playwright to 1.37 (Release Notes)
    • Most relevant update = "UI Mode now respects project dependencies" 🎉
  • Allow passing env to python command generator class

How is this patch tested? If it is not, please explain why.

  • Locally

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@sashankaryal sashankaryal self-assigned this Aug 14, 2023
@sashankaryal sashankaryal requested a review from a team August 14, 2023 19:31
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (786d2ca) 16.03% compared to head (97037bc) 16.03%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3411   +/-   ##
========================================
  Coverage    16.03%   16.03%           
========================================
  Files          571      571           
  Lines        71014    71014           
  Branches       799      799           
========================================
  Hits         11384    11384           
  Misses       59630    59630           
Flag Coverage Δ
app 16.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@manivoxel51 manivoxel51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@sashankaryal sashankaryal merged commit d3761f2 into develop Aug 14, 2023
@sashankaryal sashankaryal deleted the refactor/upgrade-pw branch August 14, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants