Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Bug in Plugins Placements JS-Example #3364

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

wayofsamu
Copy link
Contributor

@wayofsamu wayofsamu commented Aug 1, 2023

What changes are proposed in this pull request?

Fixed a small bug/ copy-paste mistake in the plugin docs.

Do you prefer small PRs like this, or should I write issues for stuff like this instead?

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@wayofsamu wayofsamu changed the title typos fixed [DOC] Typos in Plugins Placements Aug 1, 2023
@wayofsamu wayofsamu changed the title [DOC] Typos in Plugins Placements [DOC] Bug in Plugins Placements JS-Example Aug 1, 2023
@brimoor brimoor changed the base branch from develop to release/v0.21.5 August 4, 2023 03:59
@brimoor brimoor changed the base branch from release/v0.21.5 to develop August 4, 2023 03:59
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sa-Schmi. Pardon the delay. Small PRs are welcome if it improves readability. I see in this case you were aiming for improving consistency. Also welcomed. Note that plugin documentation will probably be improved internally in the coming months. Thanks!

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10% 🎉

Comparison is base (f3921aa) 15.91% compared to head (0e1065a) 16.01%.
Report is 234 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3364      +/-   ##
===========================================
+ Coverage    15.91%   16.01%   +0.10%     
===========================================
  Files          572      572              
  Lines        70525    71155     +630     
  Branches       741      800      +59     
===========================================
+ Hits         11222    11397     +175     
- Misses       59303    59758     +455     
Flag Coverage Δ
app 16.01% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 115 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane benjaminpkane merged commit 655532d into voxel51:develop Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants