-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLIP to the model zoo #1691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the contribution! 💯 🥇
Just left a couple formatting requests for you
Thanks it was a bit challenging. I guess because it's intertwined with the eta package and the bulk of the code is based upon config parsers. Overall, it was an interesting experience. Hope it will be useful for the community. |
Hi there. Can we get this one merged? I can rebase this branch to v0.16.5 |
Hey @Rusteam absolutely, merging now! This will be included in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks a lot. Just preparing to use it actually. |
What changes are proposed in this pull request?
Adds:
zero-shot
model zoo tag to let users pass custom class labels to classification. Usage template is updated to include an example of passing custom class labels. (by default it will use voc_labels.txt)How is this patch tested? If it is not, please explain why.
Added an extra unit-test for zero-shot label predictions.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
Make a zero-shot class label predictions using CLIP model by using default labels or passing your own labels.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes