モデレーターでもトークン発行画面にadmin系権限が表示されるように #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
settings/apiのアクセストークン発行画面では、adminが開くとadmin:系権限が表示されますが、これをモデレーターでも表示されるようにします。Why
admin:系権限の中にはadmin限定でないものもいくつかあり、モデレーターはapiコンソールなどからそれらのトークンを発行できるが、settings/apiのUIからはできないという状況になっています。これが微妙に不便であるため、これを修正します。
Additional info (optional)
セキュリティ的に若干不安になる変更なので本家へのPRは見送っています。（エンドポイント側がトークン主の権限をチェックする仕組みがあるので実害はないはず…）
Checklist