Enhancement/new thruster interface #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding choice, status and PWM (tested on arduino), new hpp file
…unctions from the library
…l status topic. Tested everything with the I2c connection running
…std_msgs/msg/float64_multi_array
…om/vortexntnu/vortex-asv into enhancement/new-thruster-interface
alekskl01
reviewed
Apr 28, 2024
Comment on lines
+7
to
+13
| #Path to the YAML file | ||
| yaml_file_path = os.path.join( | ||
| get_package_share_directory("thruster_interface"), | ||
| "../../../../", # Go to the workspace | ||
| "src/vortex-asv/asv_setup/config/robots/", # Go where the yaml file is located at | ||
| 'freya.yaml' | ||
| ) |
There was a problem hiding this comment.
Please use join(get_package_share_directory('asv_setup'),'config','robots','freya.yaml') instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New thruster interface for the new failsafe system.
WARNING: Note from Martynas. ONLY aprove this pull request once electrical is FINALLY DONE and TESTED and VERIFIED that the new failsafe/ESC PCB works!!!!!!!