-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update signal-hook-tokio for tokio v1.0 #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I somehow haven't managed to get around to this yet, so thanks for picking it up.
There are few details that need ironing out, but mostly this is what needed doing. Can you have a look at them?
This drops support for pre-1.0 versions of tokio, and removes the per-version features and modules.
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 63.05% 61.26% -1.79%
==========================================
Files 26 27 +1
Lines 3762 3565 -197
Branches 145 181 +36
==========================================
- Hits 2372 2184 -188
+ Misses 1389 1380 -9
Partials 1 1
|
Thank you :-). Looks good. Do you want to follow up with that cleanup right away, or should I spin up a release? |
This drops support for pre-1.0 versions of tokio, and removes the per-version features and modules.
Fixes #83.