Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix dataset-serialize benchmark by setting pre_buffer=False (#152)" #155

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

austin3dickey
Copy link
Contributor

This reverts commit d412d2f.

This benchmark was fixed in apache/arrow#38466.

@austin3dickey austin3dickey merged commit f58e572 into main Nov 21, 2023
2 checks passed
@austin3dickey austin3dickey deleted the aus/revert branch November 21, 2023 17:43
Copy link

Pull Request Test Coverage Report for Build 6947601111

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 87.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
benchmarks/dataset_serialize_benchmark.py 1 2 50.0%
Totals Coverage Status
Change from base Build 6947233233: -0.02%
Covered Lines: 1552
Relevant Lines: 1780

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant