fix(test_server): deprecated ssl_accept #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was breaking on OTP 24 for the |
|
Thanks for that, and sorry for the delay. I would actually prefer to avoid |
|
Fine for me :) Will update accordingly. |
OTP 21 deprecated the `:ssl.ssl_accept/3` function. So, we add a compile check to determine which function to call. This library supports Elixir 1.5 and so the OTP support must be present up to OTP 18.
victorolinasc
force-pushed
the
fix/deprecated_ssl_accept
branch
from
306f053
to
c330f11
Compare
|
Updated! |
Excellent. Thanks! Will merge and publish 0.8.5 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTP 21 deprecated the
:ssl.ssl_accept/3function. So, we add acompile check to determine which function to call. This library
supports Elixir 1.5 and so the OTP support must be present up to OTP 18.