Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove autoshimming #316

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Remove autoshimming #316

merged 3 commits into from
Mar 22, 2019

Conversation

charlespierce
Copy link
Contributor

Closes #235

Info

Now that #247 has landed, we can remove the autoshimming to prevent cluttering the user's path with shims to JS binaries.

Changes

  • Removed the calls to autoshim.
  • Removed the finalize method on the Tool trait, as it was only being used to support autoshimming.
  • Removed the autoshim and dependent_binary_names_fault_tolerant methods from Project.

Tested

  • Verified locally that running yarn in a project with many dependencies doesn't result in any shims being created.

dherman
dherman approved these changes Mar 22, 2019
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting…

@dherman dherman merged commit 631b85f into volta-cli:master Mar 22, 2019
@charlespierce charlespierce deleted the remove_autoshim branch March 22, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlespierce @dherman