Project autoshim #163
Merged
Project autoshim #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the call this morning, Michael raised a corner case I don't think the PR currently covers: running |
|
Missing dependencies are no longer reported as errors. |
dherman
approved these changes
Nov 8, 2018
|
|
||
| /// Convert dependency names to the path to each project. | ||
| fn get_dependency_path(&self, name: &String) -> PathBuf { | ||
| // TODO(158): Add support for Yarn Plug'n'Play. |
There was a problem hiding this comment.
Nit: the convention we use is // ISSUE(158): .
| let errors = project.autoshim(); | ||
|
|
||
| for error in errors { | ||
| display_error(&error); |
There was a problem hiding this comment.
I think I'm starting to doubt the part of the exit codes RFC that says that we should preserve the exit code of the underlying tool even if extra logic afterwards fails. We don't need to block this PR on this, but I filed an RFC issue to follow up.
|
I pushed a change to the one nit ( |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative implementation of RFC 23.
A notable change with this PR is the grammar for the
notion shimcommand, which has been moved behind thenotion-devfeature flag.notion shim=>notion shim listnotion shim foo=>notion shim create foonotion shim foo --delete=>notion shim delete foo