Fix for yarn path bug #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikrostew
force-pushed
the
yarn-node-fix
branch
from
00faa4f to
5b858ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how PATHs are constructed for running Node, Yarn, and package executables.
Every tool that is run gets the current versions of Node and Yarn in the PATH, without the Notion shims. This provides the right environment for project and user toolchains, and fixes the bug where Yarn was run with the wrong version of Node in the PATH.
I also refactored the path code, because there was a lot of duplication there, and removed
unwrap()in favor of handling the errors instead.Closes #146.