Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache installers as they're fetched #32

Closed
dherman opened this issue Feb 10, 2018 · 1 comment
Closed

cache installers as they're fetched #32

dherman opened this issue Feb 10, 2018 · 1 comment

Comments

@dherman
Copy link
Collaborator

dherman commented Feb 10, 2018

notion_core::installer::node::Installer::remote() should put a TeeReader around its input source to save the results to a cache file. The cache file should be stored in a directory specified by notion_core::path::node_cache_dir().

@dherman
Copy link
Collaborator Author

dherman commented Apr 28, 2018

This issue must have been filed in a moment of forgetfulness — both the tarball and zip versions already generate the cache file. The logic lives in the fetch function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants