You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sandboxing logic we use for testing is a bit messier than it could be. I think we can clean it up by eliminating the NOTION_SANDBOX env var and not changing HOME or USERPROFILE, and just use NOTION_HOME as the main hook for sandboxing.
Rough plan:
don't change HOME or USERPROFILE -- don't need to isolate behavior of tools we're delegating to
The sandboxing logic we use for testing is a bit messier than it could be. I think we can clean it up by eliminating the
NOTION_SANDBOX
env var and not changingHOME
orUSERPROFILE
, and just useNOTION_HOME
as the main hook for sandboxing.Rough plan:
HOME
orUSERPROFILE
-- don't need to isolate behavior of tools we're delegating toNOTION_HOME
as only sandboxing hook~/.notion
C:\Users\$username\AppData\Local\Notion
NOTION_HOME
to$unique/.notion
on all platformspath::mod
should define notion_homeNOTION_HOME
is set, use thatdefault_notion_home()
path::$os
should definedefault_notion_home
${dirs::home_dir()}/.notion
(seedirs::home_dir()
)${dirs::data_local_dir()}/Notion
(seedirs::data_local_dir()
)notion_home()
NOTION_SANDBOX
It might be best to wait until #181 is done to implement this, since that touches these files a fair amount.
The text was updated successfully, but these errors were encountered: