Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write eos in cpp #24

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Write eos in cpp #24

wants to merge 23 commits into from

Conversation

volpatto
Copy link
Owner

@volpatto volpatto commented Sep 1, 2019

This PR translates the EoS to C++. This was done due to computational performance. The EoS written in Python is too slow, and the global optimization method is already computationally demanding. This PR tries to amend the overall computational cost and lower time complexity.

@codecov-io
Copy link

codecov-io commented Sep 1, 2019

Codecov Report

Merging #24 into master will decrease coverage by 8.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #24     +/-   ##
=========================================
- Coverage      78%   69.81%   -8.2%     
=========================================
  Files           8        9      +1     
  Lines         482      318    -164     
  Branches       68       50     -18     
=========================================
- Hits          376      222    -154     
+ Misses         85       77      -8     
+ Partials       21       19      -2
Impacted Files Coverage Δ
gibbs/stability_analysis.py 77.14% <ø> (ø) ⬆️
gibbs/_cpp_wrapper.py 100% <100%> (ø)
gibbs/mixture.py 100% <100%> (ø) ⬆️
gibbs/phase_envelope.py 100% <100%> (ø) ⬆️
gibbs/phase_identification.py 100% <100%> (ø) ⬆️
gibbs/models/ceos.py 100% <100%> (+9.39%) ⬆️
gibbs/equilibrium.py 59.13% <0%> (-3.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46c72...0ab9b73. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants