Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vc job phase setting #746

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix vc job phase setting #746

merged 1 commit into from
Mar 25, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

Fixes: #740

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 08783de0-6e48-11ea-bb6d-3b4611825122

@k82cn
Copy link
Member

k82cn commented Mar 25, 2020

/approve

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6f9047e0-6e5a-11ea-bef5-ab2a7fe30e4a

@hzxuzhonghu
Copy link
Collaborator Author

@k82cn please re-tag

@k82cn
Copy link
Member

k82cn commented Mar 25, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit cefeaa9 into volcano-sh:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcjob should store err_msg and set it's status to failed when it's task failed
4 participants
@hzxuzhonghu @TravisBuddy @k82cn @volcano-sh-bot