Change Statement unevict method to call UpdateTask #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change ensures that when
unevict
is called the value ofnodeInfo.Releasing
will be updated as if the task was evicted.Before this fix, because the task exists on the current
nodeInfo
, every timeunevict
is called theReleasing
value of the nodeInfo isn't updated and the value remains same as if the task wasevicted
Why does it happen:
This happens because
unevict
callsAddTask
:AddTask
will throw an error because this task already exists under the current nodeInfo and therefore will not update theReleasing
field as if the current task isRunning
Issue: #907
This fix was added to kube-batch: kubernetes-retired/kube-batch#912