fix pg controller create redundancy podGroup when schedulerName isn't matched #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
liuyuanchun11
force-pushed
the
fixRedunPg
branch
from
9a57bd6
to
31d5ca5
Compare
volcano-sh-bot
added
size/XS
Monokaix
reviewed
Aug 13, 2024
| @@ -93,6 +94,10 @@ func (pg *pgcontroller) addReplicaSet(obj interface{}) { | |||
| if podList != nil && len(podList.Items) > 0 { | |||
| pod := podList.Items[0] | |||
| klog.V(4).Infof("Try to create podgroup for pod %s/%s", pod.Namespace, pod.Name) | |||
| if !slices.Contains(pg.schedulerNames, pod.Spec.SchedulerName) { | |||
| klog.V(4).Infof("pod %s/%s field SchedulerName is not matched", pod.Namespace, pod.Name) | |||
There was a problem hiding this comment.
Please change pod to upper case.
There was a problem hiding this comment.
And we can use klog.Kobj to print pod.namespace and pos.name.
… matched Signed-off-by: liuyuanchun <[email protected]>
liuyuanchun11
force-pushed
the
fixRedunPg
branch
from
31d5ca5
to
267defc
Compare
volcano-sh-bot
added
size/S
Monokaix
reviewed
Aug 15, 2024
| return | ||
| } | ||
| if podList != nil && len(podList.Items) > 0 { | ||
| pod := podList.Items[0] | ||
| klog.V(4).Infof("Try to create podgroup for pod %s/%s", pod.Namespace, pod.Name) | ||
| klog.V(4).Infof("Try to create podgroup for pod %s", klog.KObj(&pod)) |
There was a problem hiding this comment.
The value must be a pointer. pod:= podList.Items[0], pod is not a pointer.
Monokaix
reviewed
Aug 15, 2024
| err := pg.createNormalPodPGIfNotExist(&pod) | ||
| if err != nil { | ||
| klog.Errorf("Failed to create PodGroup for pod <%s/%s>: %v", pod.Namespace, pod.Name, err) | ||
| klog.Errorf("Failed to create PodGroup for pod %s: %v", klog.KObj(&pod), err) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #3671
Check whether the value of pod.spec.schedulerName is matched before creating a podGroup.