-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add oidc's auth provider #3663
Conversation
Welcome @snappyyouth! |
Signed-off-by: pengfei <[email protected]>
/ok-to-test |
The image in description is missing: ) |
thx for the reminder.I has supplemented some images in the description . |
/lgtm |
Will it have any impact on the current usage, or output more error logs without using oidc? |
Sorry, I don't quite understand what you mean? |
I mean if i don't use oidc. Will this change cause any confusion for me? |
if you don't use oidc. This change will't cause any confusion for you. Errors only occur when registering repeatedly. And when your config didn't use oidc, AuthProvider is nil. The program will skip. All in all, it's completely safe! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#3662
What is the problem you're trying to solve
I will like to add support to scheduler such that also clusters that use oidc authentication will work.
webhook-manager belike:
controller-manager belike:
scheduler belike:
Describe the solution you'd like
add oidc's auth provider in the /cmd/scheduler/main.go /cmd/webhook-manager/main.go /cmd/controller-manager/main.go
_ "k8s.io/client-go/plugin/pkg/client/auth"
Arfter adding, all the comment running expectedly.
controller-manager belike:
scheduler belike: