Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose volcano components (controller, scheduler, etc.) log level control to the helm chat values #3656

Merged
merged 1 commit into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions installer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,11 @@ The following are the list configurable parameters of Volcano Chart and their de
|`custom.scheduler_labels`|Labels for Scheduler deployment|`~`|
|`custom.common_labels`|Labels for all chart objects except for CRDs |`~`|
|`custom.admission_resources`|Resources for Admission pods|`~`|
|`custom.admission_log_level`|Settings log print level for Admission|`4`|
|`custom.controller_resources`|Resources for Controller pods|`~`|
|`custom.controller_log_level`|Settings log print level for Controller|`4`|
|`custom.scheduler_resources`|Resources for Scheduler pods|`~`|
|`custom.scheduler_log_level`|Settings log print level for Scheduler|`3`|
|`custom.webhooks_namespace_selector_expressions`|Additional namespace selector expressions for Volcano admission webhooks|`~`|

Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,
Expand Down
2 changes: 1 addition & 1 deletion installer/helm/chart/volcano/templates/admission.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ spec:
- --enable-healthz=true
- --logtostderr
- --port={{.Values.basic.admission_port}}
- -v=4
- -v={{.Values.custom.admission_log_level}}
- 2>&1
image: {{ .Values.basic.image_registry }}/{{.Values.basic.admission_image_name}}:{{.Values.basic.image_tag_version}}
imagePullPolicy: {{ .Values.basic.image_pull_policy }}
Expand Down
2 changes: 1 addition & 1 deletion installer/helm/chart/volcano/templates/controllers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ spec:
{{- if .Values.custom.leader_elect_enable }}
- --leader-elect-resource-namespace={{ .Release.Namespace }}
{{- end }}
- -v=4
- -v={{.Values.custom.controller_log_level}}
- 2>&1
imagePullPolicy: {{ .Values.basic.image_pull_policy }}
{{- end }}
2 changes: 1 addition & 1 deletion installer/helm/chart/volcano/templates/scheduler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ spec:
{{- if .Values.custom.leader_elect_enable }}
- --leader-elect-resource-namespace={{ .Release.Namespace }}
{{- end }}
- -v=3
- -v={{.Values.custom.scheduler_log_level}}
- 2>&1
env:
- name: DEBUG_SOCKET_DIR
Expand Down
6 changes: 6 additions & 0 deletions installer/helm/chart/volcano/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ custom:
scheduler_resources: ~
controller_resources: ~


# Specify additional namespace selector expressions for Volcano admission webhooks.
# For example, if you want Volcano admission webhooks take effect in namespaces with
# label key="workload-type" and value="batch", and don't take effect in namespaces with
Expand All @@ -141,3 +142,8 @@ custom:
# Note that {{ .Release.Namespace }} and kube-system namespaces are always ignored.
webhooks_namespace_selector_expressions: ~


# Specify log level for Volcano main component
admission_log_level: 4
scheduler_log_level: 3
controller_log_level: 4
Loading