feat:adding sidecar #3589
feat:adding sidecar #3589
Conversation
|
Welcome @7h3-3mp7y-m4n! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/M
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
|
Unit test is need! |
| @@ -43,6 +43,8 @@ const ( | |||
|
|
|||
| // ResourceTopology supports resources like cpu/memory topology aware. | |||
| ResourceTopology featuregate.Feature = "ResourceTopology" | |||
|
|
|||
There was a problem hiding this comment.
Can we add comment and reference documents to let users know the context of this feature gate?
There was a problem hiding this comment.
SidecarContainers is a kubernetes intree feature and has already a definition，and now we have imported other features like https://github.com/volcano-sh/volcano/blob/224ca98ab097d7788fc17ae5a6bbb0ba7a191653/pkg/scheduler/plugins/predicates/predicates.go#L291，so we doesn't need to re-define the feature.
okay :) |
|
Hi, since it's not active and we will release v1.10 soon so I fire a new PR based on your work and your commit is also inclueded, thanks for your contribution! |
volcano-sh-bot
added
the
needs-rebase
|
@7h3-3mp7y-m4n: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
|
@lowang-bh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This added a feature of sidecar
Fixes #3513