Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gates flag #3571

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Jul 9, 2024

Add feature gates flag to support user disable some features by command line.

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2024
@Monokaix Monokaix force-pushed the featuregates branch 4 times, most recently from ab5aab8 to 446be12 Compare July 9, 2024 08:18
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
Signed-off-by: Xuzheng Chang <[email protected]>
@wangyang0616
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@william-wang
Copy link
Member

@Monokaix Suggest add a guide to introduce the current featuregate :)

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@volcano-sh-bot volcano-sh-bot merged commit 94944b5 into volcano-sh:master Jul 10, 2024
14 checks passed
googs1025 pushed a commit to googs1025/volcano that referenced this pull request Jul 10, 2024
Add feature gates flag

Signed-off-by: googs1025 <[email protected]>
@Monokaix Monokaix deleted the featuregates branch July 26, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants