Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete reservation plugin doc #3546

Merged
merged 1 commit into from
Sep 4, 2024
Merged

delete reservation plugin doc #3546

merged 1 commit into from
Sep 4, 2024

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Jun 27, 2024 •
edited
Loading

Reservation plugin has been deleted. This doc is no longer needed. It will confuse users.
Additionally, I recommend cleaning up documents that have expired.

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2024
@hwdef
Copy link
Member Author

hwdef commented Jun 27, 2024

/assign @Monokaix @lowang-bh

@Monokaix
Copy link
Member

have the problems mentioned in this doc been resolved?
And I saw that #748 mentioned that this feature is released, but I didn't see that.

@hwdef
Copy link
Member Author

hwdef commented Jun 27, 2024

I think the reservation plugin has been deprecated and replaced by the SLA plugin.
@Thor-wl Can you clarify?

googs1025
googs1025 reviewed Jun 27, 2024
View reviewed changes
docs/design/job-resource-reservation-design.md Outdated
@@ -1,148 +0,0 @@
# Volcano Resource Reservation For Target Jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a deprecated directory and put this design document in it instead of deleting it directly. This way users can also refer to the previous documents. @Monokaix WDYT

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a deprecated directory and put this design document in it instead of deleting it directly. This way users can also refer to the previous documents. @Monokaix WDYT

If users want to view old documents, they can switch to the old branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mark it as deprecated and delete it in next version: )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monokaix
how to mark it as deprecated? write in title? create a deprecated folder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just edit the doc directly: ), and whether it's sovled by sla-plugin should also be checked.

@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2024
@hwdef
Copy link
Member Author

hwdef commented Sep 3, 2024

@Monokaix @googs1025
The docs has been updated. Please review again.

@hwdef hwdef closed this Sep 3, 2024
@hwdef hwdef deleted the delete-reservation-docs branch September 3, 2024 07:51
@hwdef hwdef restored the delete-reservation-docs branch September 3, 2024 07:51
@hwdef hwdef reopened this Sep 3, 2024
@googs1025
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@Monokaix
Copy link
Member

Monokaix commented Sep 4, 2024

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@volcano-sh-bot volcano-sh-bot merged commit 3541a23 into volcano-sh:master Sep 4, 2024
23 of 25 checks passed
@hwdef hwdef deleted the delete-reservation-docs branch September 4, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googs1025 googs1025 googs1025 left review comments

@Monokaix Monokaix Monokaix left review comments

@archlitchi archlitchi Awaiting requested review from archlitchi

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@Monokaix Monokaix

@lowang-bh lowang-bh

@googs1025 googs1025

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwdef @Monokaix @googs1025 @volcano-sh-bot @lowang-bh