Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pod annotation with job RetryCount #3544

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Added pod annotation with job RetryCount #3544

merged 1 commit into from
Jul 12, 2024

Conversation

belo4ya
Copy link
Contributor

@belo4ya belo4ya commented Jun 25, 2024

Added pod annotation with current Job RetryCount version: volcano.sh/job-retry-count=<Job.Status.RetryCount>

feat #3528

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
Monokaix
Monokaix reviewed Jun 26, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@belo4ya belo4ya force-pushed the retry-count-in-pod-annotations branch from 0d93fa9 to 62befb1 Compare July 9, 2024 10:23
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
belo4ya
belo4ya commented Jul 9, 2024
View reviewed changes
go.mod Outdated
@@ -171,4 +171,5 @@ replace (
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.30.2
k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.30.2
k8s.io/sample-controller => k8s.io/sample-controller v0.30.2
volcano.sh/apis => github.com/volcano-sh/apis v1.10.0-alpha.0.0.20240709084748-78d912ce096c
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't do it without adding this line(

go get github.com/volcano-sh/apis@master
go: github.com/volcano-sh/apis@master (v1.10.0-alpha.0.0.20240709084748-78d912ce096c) requires github.com/volcano-sh/[email protected]: parsing go.mod:
        module declares its path as: volcano.sh/apis
                but was required as: github.com/volcano-sh/apis

Perhaps this is due to the fact that the changes have been included in the master, but have not yet been included in any tag.

As far as I understand, I still have to wait for the next tag to appear in volcano-sh/apis and then make changes again?

Copy link
Member

@Monokaix Monokaix Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should modify go mod volcano.sh/apis' tag to your commit id，and then execute go mod tidy，also the prefix github.com is unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it worked

@belo4ya belo4ya force-pushed the retry-count-in-pod-annotations branch from 62befb1 to a739841 Compare July 9, 2024 13:46
@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
hwdef
hwdef reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

william-wang
william-wang approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@volcano-sh-bot volcano-sh-bot merged commit 22f9dc4 into volcano-sh:master Jul 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@william-wang william-wang

@Monokaix Monokaix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@belo4ya @Monokaix @volcano-sh-bot @william-wang @hwdef