Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vcctl job list queueName filter #3524

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

googs1025
Copy link
Member

@googs1025 googs1025 commented Jun 15, 2024

What type of PR is this?

/kind feature
New features: support filter vcjob by specifying the queue
-q, --queue string list job with specified queue name

What this PR does / why we need it:

  • Add vcctl job command feature
    • -q: filter jobs that use a specific queue
  • add unit test for job list

Which issue(s) this PR fixes:

Fixes #3495

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added vcctl job command feature

How to use it:

root@VM-0-9-ubuntu:~/volcano/_output/bin# vcctl job list -h
list job information

Usage:
  vcctl job list [flags]

Flags:
      --all-namespaces      list jobs in all namespaces
  -h, --help                help for list
 ...
  -q, --queue string        list job with specified queue name
  ...

root@VM-0-9-ubuntu:~/volcano/_output/bin# vcctl job list -q=default
Name                    Creation       Phase       JobType     Replicas    Min   Pending   Running   Succeeded   Failed    Unknown     RetryCount
tensorflow-dist-mnist   2024-06-04     Completed   Batch       3           3     0         0         2           0         0           0
root@VM-0-9-ubuntu:~/volcano/_output/bin# vcctl job list -q=test
No resources found

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None


@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 15, 2024
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2024
@googs1025 googs1025 mentioned this pull request Jun 15, 2024
5 tasks
@googs1025
Copy link
Member Author

/assign @Monokaix

@googs1025 googs1025 force-pushed the vcctl_job_command branch 2 times, most recently from 805b603 to 57660a3 Compare June 15, 2024 03:57
@Monokaix
Copy link
Member

Monokaix commented Jun 17, 2024

It's better to identify the new function points to distinguish them from the original functions in vcctl ouput.

@googs1025
Copy link
Member Author

It's better to identify the new function points to distinguish them from the original functions in vcctl ouput.

done

pkg/cli/job/list.go Outdated Show resolved Hide resolved
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@googs1025 googs1025 requested a review from Monokaix July 11, 2024 09:55
@Monokaix
Copy link
Member

Monokaix commented Aug 3, 2024

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2024
@volcano-sh-bot volcano-sh-bot merged commit 0fa8102 into volcano-sh:master Aug 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement vcctl features
4 participants