Add common labels for chart objects #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/L
Aakcht
force-pushed
the
add_common_labels
branch
2 times, most recently
from
9fa303d
to
4adabb9
Compare
Monokaix
reviewed
Jun 5, 2024
Aakcht
force-pushed
the
add_common_labels
branch
3 times, most recently
from
46dc05f
to
c90f983
Compare
|
/lgtm |
|
Looks like the DCO check got stuck for some reason, should I try rebasing the PR? |
Yeah, you can have a try. |
Aakcht
force-pushed
the
add_common_labels
branch
from
c90f983
to
62c2ff4
Compare
|
@Monokaix looks like the rebase helped, please take a look |
Aakcht
force-pushed
the
add_common_labels
branch
from
62c2ff4
to
07cc7c3
Compare
Aakcht
force-pushed
the
add_common_labels
branch
from
07cc7c3
to
8fbc9ad
Compare
Signed-off-by: aakcht <[email protected]>
Aakcht
force-pushed
the
add_common_labels
branch
from
8fbc9ad
to
ad35aa5
Compare
|
@william-wang @Monokaix please take a look, I had to do one more rebase to fix merge conflicts |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to set common labels for all chart objects except for CRDs