Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vcctl jobtemplate #3507

Closed
wants to merge 1 commit into from

Conversation

googs1025
Copy link
Member

@googs1025 googs1025 commented Jun 3, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Added vcctl jobtemplate command feature
    • create : Support -f (file) to pass in yaml file to create jobtemplate resource
    • delete: Support -f (file) to pass in yaml file to delete jobtemplate resource or -N(name) -n(namespace) to delete jobtemplate resource
    • describe: Support -o, --format to output in yaml or json format, -N(name) -n(namespace) to inquire
    • list: Support -n(namespace) to inquire
    • get: Support -N(name) -n`(namespace) to inquire

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added vcctl jobtemplate command feature

root@VM-0-9-ubuntu:~# vcctl jobtemplate delete -f jobtemplate.yaml
Deleted JobTemplate: default/a
Deleted JobTemplate: default/b
Deleted JobTemplate: default/c
Deleted JobTemplate: default/d
Deleted JobTemplate: default/e
Deleted 5 JobTemplates successfully

root@VM-0-9-ubuntu:~# vcctl jobtemplate create -f jobtemplate.yaml
Created JobTemplate: default/a
Created JobTemplate: default/b
Created JobTemplate: default/c
Created JobTemplate: default/d
Created JobTemplate: default/e

root@VM-0-9-ubuntu:~# vcctl jobtemplate get -N=a
Name    Namespace
a       default

root@VM-0-9-ubuntu:~# vcctl jobtemplate list
Name    Namespace
a       default
b       default
c       default
d       default
e       default

root@VM-0-9-ubuntu:~# vcctl jobtemplate describe -N=a
metadata:
  creationTimestamp: "2024-06-03T12:20:28Z"
  generation: 1
  managedFields:
  - apiVersion: flow.volcano.sh/v1alpha1
    fieldsType: FieldsV1
    fieldsV1:
...

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None


@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 3, 2024
@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 3, 2024
@volcano-sh-bot volcano-sh-bot requested a review from k82cn June 3, 2024 12:38
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 3, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. labels Jun 3, 2024
@volcano-sh-bot
Copy link
Contributor

@googs1025: The label(s) kind/deprecation, kind/regression cannot be applied. These labels are supported: ``

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Added vcctl jobtemplate command feature
  • create : Support -f (file) to pass in yaml file to create jobtemplate resource
  • delete: Support -f (file) to pass in yaml file to delete jobtemplate resource or -N(name) -n(namespace) to delete jobtemplate resource
  • describe: Support -o, --format to output in yaml or json format, -N(name) -n(namespace) to inquire
  • list: Support -n(namespace) to inquire
  • get: Support -N(name) -n`(namespace) to inquire

Which issue(s) this PR fixes:

Fixes #3495

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added vcctl jobtemplate command feature

root@VM-0-9-ubuntu:~# vcctl jobtemplate delete -f jobtemplate.yaml
Deleted JobTemplate: default/a
Deleted JobTemplate: default/b
Deleted JobTemplate: default/c
Deleted JobTemplate: default/d
Deleted JobTemplate: default/e
Deleted 5 JobTemplates successfully

root@VM-0-9-ubuntu:~# vcctl jobtemplate create -f jobtemplate.yaml
Created JobTemplate: default/a
Created JobTemplate: default/b
Created JobTemplate: default/c
Created JobTemplate: default/d
Created JobTemplate: default/e

root@VM-0-9-ubuntu:~# vcctl jobtemplate get -N=a
Name    Namespace
a       default

root@VM-0-9-ubuntu:~# vcctl jobtemplate list
Name    Namespace
a       default
b       default
c       default
d       default
e       default

root@VM-0-9-ubuntu:~# vcctl jobtemplate describe -N=a
metadata:
 creationTimestamp: "2024-06-03T12:20:28Z"
 generation: 1
 managedFields:
 - apiVersion: flow.volcano.sh/v1alpha1
   fieldsType: FieldsV1
   fieldsV1:
...

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 3, 2024
@googs1025 googs1025 closed this Jun 3, 2024
@volcano-sh-bot
Copy link
Contributor

@googs1025: The label(s) kind/deprecation, kind/regression cannot be applied. These labels are supported: ``

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Added vcctl jobtemplate command feature
  • create : Support -f (file) to pass in yaml file to create jobtemplate resource
  • delete: Support -f (file) to pass in yaml file to delete jobtemplate resource or -N(name) -n(namespace) to delete jobtemplate resource
  • describe: Support -o, --format to output in yaml or json format, -N(name) -n(namespace) to inquire
  • list: Support -n(namespace) to inquire
  • get: Support -N(name) -n`(namespace) to inquire

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added vcctl jobtemplate command feature

root@VM-0-9-ubuntu:~# vcctl jobtemplate delete -f jobtemplate.yaml
Deleted JobTemplate: default/a
Deleted JobTemplate: default/b
Deleted JobTemplate: default/c
Deleted JobTemplate: default/d
Deleted JobTemplate: default/e
Deleted 5 JobTemplates successfully

root@VM-0-9-ubuntu:~# vcctl jobtemplate create -f jobtemplate.yaml
Created JobTemplate: default/a
Created JobTemplate: default/b
Created JobTemplate: default/c
Created JobTemplate: default/d
Created JobTemplate: default/e

root@VM-0-9-ubuntu:~# vcctl jobtemplate get -N=a
Name    Namespace
a       default

root@VM-0-9-ubuntu:~# vcctl jobtemplate list
Name    Namespace
a       default
b       default
c       default
d       default
e       default

root@VM-0-9-ubuntu:~# vcctl jobtemplate describe -N=a
metadata:
 creationTimestamp: "2024-06-03T12:20:28Z"
 generation: 1
 managedFields:
 - apiVersion: flow.volcano.sh/v1alpha1
   fieldsType: FieldsV1
   fieldsV1:
...

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. kind/flake Categorizes issue or PR as related to a flaky test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants