-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unit-test && e2e to run on Mac #3506
Conversation
Welcome @yeahdongcn! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fixes #2894 |
Signed-off-by: Xiaodong Ye <[email protected]>
Code rebase from upstream/master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I encountered several issues in
make controller-gen
,make unit-test
,make e2e
on Mac.Please see the detailed error message here:
make controller-gen
make unit-test
This is because
GOOS ?= linux
is explicitly set inMakefile
and consumed in making docker images, etc.So I slightly update the
OS
env and access it whenever needed (e.g.go test/install
,ginkgo
) and everything works perfectly on Mac && Linux.Testing done (on both Mac && Linux):
make vcctl
-> okmake unit-test
-> okmake controller-gen
-> okmake mirror-licenses
-> okmake generate-code
-> okmake e2e-test-jobp
-> ok