Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lock before read Jobs map #3478 #3479

Merged
merged 1 commit into from
May 31, 2024
Merged

add lock before read Jobs map #3478 #3479

merged 1 commit into from
May 31, 2024

Conversation

Wang-Kai
Copy link
Contributor

add lock before read Jobs map in syncTask function

@volcano-sh-bot
Copy link
Contributor

Welcome @Wang-Kai!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2024
googs1025
googs1025 reviewed May 21, 2024
View reviewed changes
pkg/scheduler/cache/event_handlers.go
@@ -258,6 +258,8 @@ func (sc *SchedulerCache) syncTask(oldTask *schedulingapi.TaskInfo) error {
newPod, err := sc.kubeClient.CoreV1().Pods(oldTask.Namespace).Get(context.TODO(), oldTask.Name, metav1.GetOptions{})
if err != nil {
if errors.IsNotFound(err) {
sc.Mutex.Lock()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to use lock in notfound error as well. this error is not common, but it works if we add it.
nice catch! :)

@googs1025
Copy link
Member

@Wang-Kai DCO signature is required when submitting a commit!

@lowang-bh
Copy link
Member

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 21, 2024
@Monokaix
Copy link
Member

Hi, please sign off you commit with git commit -s.

@Wang-Kai
Copy link
Contributor Author

Hi, please sign off you commit with git commit -s.

Sorry for the delay. I just executed the git commit --amend -s command and pushed again.

@Wang-Kai Wang-Kai force-pushed the fix-scheduler-synctask-panic branch from 2f36fb4 to acb43cb Compare May 24, 2024 12:58
@lowang-bh
Copy link
Member

Please rebase and squash commits to only one.

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2024
@Wang-Kai Wang-Kai force-pushed the fix-scheduler-synctask-panic branch from 6e274a7 to 6ffc12d Compare May 30, 2024 11:18
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2024
@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
william-wang
william-wang approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@volcano-sh-bot volcano-sh-bot merged commit fd40753 into volcano-sh:master May 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googs1025 googs1025 googs1025 left review comments

@william-wang william-wang william-wang approved these changes

@hudson741 hudson741 Awaiting requested review from hudson741

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@william-wang william-wang

@Monokaix Monokaix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Wang-Kai @volcano-sh-bot @googs1025 @lowang-bh @Monokaix @william-wang