Added documentation on what must be done to adapt volcano to the k8s version upgrade. #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
Monokaix
reviewed
May 10, 2024
docs/design/adapt-k8s-todo.md
Outdated
| 3. Other commits are to solve compilation and other problems that arise after adaptation, including API changes, scheduling policy updates, function name changes, etc. When solving, you can refer to the changelog released during the k8s upgrade. | ||
| 4. Run unit-test and ensure it passes. | ||
| 5. Run e2e verification on the specified version clusters and pass it (including the latest k8s version and historical versions). | ||
| 6. Update the Kubernetes compatibility of README file. |
There was a problem hiding this comment.
Please add that volcano should support kube-scheduler's new beta features, and these features are tracked using separate issues and PRs
There was a problem hiding this comment.
Also boldfaced to highlight, other important parts should also be boldfaced .
guoqinwill
force-pushed
the
adaptk8s-todo-doc
branch
from
b5df8da
to
ea5b5c5
Compare
lowang-bh
reviewed
May 11, 2024
docs/design/adapt-k8s-todo.md
Outdated
| ## TODO things for upgrade | ||
|
|
||
| #### Upgrade volcano apis | ||
| First,we need to upgrade the k8s version of volcano apis, such as:https://github.com/volcano-sh/apis/pull/124. |
There was a problem hiding this comment.
A blank space is need after First,.
…version Signed-off-by: guoqinwill <[email protected]>
guoqinwill
force-pushed
the
adaptk8s-todo-doc
branch
from
ea5b5c5
to
d910b77
Compare
|
/lgtm |
william-wang
approved these changes
May 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation on what must be done to adapt volcano to the k8s version upgrade.