-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: log when outputting preempt error #3447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Apr 28, 2024
googs1025
force-pushed
the
refector_preempt
branch
from
April 28, 2024 12:51
8140beb
to
2f13c94
Compare
volcano-sh-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Apr 28, 2024
lowang-bh
reviewed
Apr 28, 2024
googs1025
force-pushed
the
refector_preempt
branch
from
April 28, 2024 14:47
2f13c94
to
6548d97
Compare
volcano-sh-bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Apr 28, 2024
googs1025
force-pushed
the
refector_preempt
branch
from
April 30, 2024 15:37
6548d97
to
24cc562
Compare
volcano-sh-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Apr 30, 2024
Monokaix
reviewed
May 8, 2024
googs1025
force-pushed
the
refector_preempt
branch
from
May 8, 2024 01:59
24cc562
to
e0201ed
Compare
volcano-sh-bot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
May 10, 2024
googs1025
force-pushed
the
refector_preempt
branch
from
May 10, 2024 11:47
e0201ed
to
3f01b44
Compare
volcano-sh-bot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
May 10, 2024
lowang-bh
reviewed
May 11, 2024
googs1025
force-pushed
the
refector_preempt
branch
2 times, most recently
from
May 11, 2024 13:17
a0bea73
to
6365091
Compare
lowang-bh
reviewed
May 14, 2024
googs1025
force-pushed
the
refector_preempt
branch
from
May 14, 2024 08:37
6365091
to
2d24ecc
Compare
Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
refector_preempt
branch
from
May 14, 2024 08:38
2d24ecc
to
e74d9c6
Compare
@lowang-bh @Monokaix /PTAL thanks! |
/lgtm |
/lgtm |
lowang-bh
approved these changes
May 23, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
log when outputting preempt error
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: