filter out those nodes which are UnschedulableAndUnresolvable when preempting #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
do-not-merge/work-in-progress
volcano-sh-bot
added
the
size/XS
volcano-sh-bot
added
size/L
lowang-bh
changed the title
volcano-sh-bot
removed
the
do-not-merge/work-in-progress
|
/assign @Monokaix @hwdef @wangyang0616 |
volcano-sh-bot
added
size/XL
|
/assign @Monokaix @hwdef @wangyang0616 @william-wang |
lowang-bh
force-pushed
the
refactPreempt
branch
2 times, most recently
from
241d974
to
9509548
Compare
Monokaix
reviewed
May 23, 2024
Monokaix
reviewed
May 23, 2024
Monokaix
reviewed
May 23, 2024
volcano-sh-bot
added
the
needs-rebase
volcano-sh-bot
removed
the
needs-rebase
used in preempting Signed-off-by: lowang-bh <[email protected]>
Signed-off-by: lowang-bh <[email protected]>
Monokaix
reviewed
Jun 26, 2024
Monokaix
reviewed
Jun 26, 2024
lowang-bh
force-pushed
the
refactPreempt
branch
2 times, most recently
from
1a261ee
to
a63546d
Compare
Merged
Signed-off-by: lowang-bh <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3071
Part of enhancement for preemption action #3074
Those nodes with status UnschedulableAndUnresolvable is not helpful for preempting. So we can use cached predicating result to reduce the nodes numbers when scan for a victim pod.
we can also use the new Api
NewFitStatusto return an error in predicating to fix issue Predicate function retrun value is not compatiable with old plugins #3086main changes:
commit-1: add predicate result code to task's fitError
commit-2: testcase about fitErrors
commit-3: filter out those nodes which are not helpful for preemption in preempt/reclaim actions