[cherry-pick for release-1.9]fix jobflow CRD metadata.annotations: Too long error #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XXL
guoqinwill
changed the title
guoqinwill
force-pushed
the
fix-annotatin-too-long-1.9
branch
from
18340d4
to
4d32ea8
Compare
shinytang6
suggested changes
Mar 18, 2024
Makefile
Outdated
| @@ -114,6 +114,8 @@ manifests: controller-gen | |||
| $(CONTROLLER_GEN) "crd:maxDescLen=0,crdVersions=v1beta1" paths="./vendor/volcano.sh/apis/pkg/apis/batch/v1alpha1" output:crd:artifacts:config=config/crd/volcano/v1beta1 | |||
| # jobflow crd base | |||
| $(CONTROLLER_GEN) $(CRD_OPTIONS) paths="./vendor/volcano.sh/apis/pkg/apis/flow/v1alpha1" output:crd:artifacts:config=config/crd/jobflow/bases | |||
| # generate volcano jobflow crd yaml without description to avoid yaml size limit when using `kubectl apply` | |||
added 2 commits
March 18, 2024 16:39
Signed-off-by: wangyang <[email protected]> Signed-off-by: guoqinwill <[email protected]>
Signed-off-by: wangyang <[email protected]> Signed-off-by: guoqinwill <[email protected]>
guoqinwill
force-pushed
the
fix-annotatin-too-long-1.9
branch
from
4d32ea8
to
403667f
Compare
|
/LGTM |
|
/lgtm |
william-wang
approved these changes
Apr 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick：#3347