Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhanced FitError of JobInfo by logging the insufficient resources #3052

Closed
wants to merge 1 commit into from
Closed

fix: enhanced FitError of JobInfo by logging the insufficient resources #3052

wants to merge 1 commit into from

Conversation

srikanth-iyengar
Copy link

fix #2993

@volcano-sh-bot
Copy link
Contributor

Welcome @srikanth-iyengar!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 13, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Aug 13, 2023
…ent resources

this will help in identifying reasons for insufficient resources

Signed-off-by: Iyengar, Srikanth <[email protected]>
@lowang-bh
Copy link
Member

/hold

@volcano-sh-bot volcano-sh-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@lowang-bh
Copy link
Member

lowang-bh commented Aug 14, 2023

Hi, @srikanth-iyengar , thanks for your hard work on this issue. Actually, the filter result is already exist and don't need to do any calculations. You can find out the first failed scheduling pod's message and append to the podgroup's message. Just like this highlight in picture:
image

pod's message has been fixed in #3051. FYI.

@srikanth-iyengar
Copy link
Author

srikanth-iyengar commented Aug 14, 2023

Something like this @lowang-bh ?
image

@stale
Copy link

stale bot commented Oct 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2023
@lowang-bh
Copy link
Member

/close

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2023
@volcano-sh-bot
Copy link
Contributor

@lowang-bh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize log output when resources are not enough
3 participants