Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobflow-related content to Volcano automatic installation and deployment #2936

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

wangyang0616
Copy link
Member

@wangyang0616 wangyang0616 commented Jun 26, 2023

Add the crd definition and helm package content of jobflow, and solve the problem that the content of the helm package in #2882 exceeds the upper limit of 1MB.

The specific content is as follows:
The crd in Volcano is divided into two file groups to independently manage the contents of the helm package

  1. Volcano file group: existing Volcano crd definition
  2. jobflow file group: jobflow related crd definition
    Install jobflow as a dependency of Volcano

When the user's local source code uses helm to deploy Volcano, perform the following operations:

  1. helm dependency update installer/helm/chart/volcano
  2. helm install volcano installer/helm/chart/volcano

Compared with the master, the operation of updating the dependent chart package in the first step is added

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 26, 2023
@wangyang0616 wangyang0616 changed the title Fix jobflow upgrade Add jobflow-related content to Volcano automatic installation and deployment Jun 26, 2023
@wangyang0616 wangyang0616 force-pushed the fix_jobflow_upgrade branch 2 times, most recently from 02008c3 to c003d05 Compare June 26, 2023 12:23
… a dependent manner to solve the problem that a single chart package exceeds the 1MB limit

Signed-off-by: wangyang <[email protected]>
@lowang-bh
Copy link
Member

lowang-bh commented Jun 29, 2023

I test the helm install and it works.

One more thing, user need to run two commands when installing it first time. And user will met an error and the prompted helm dependency build does not work.
Error: INSTALLATION FAILED: An error occurred while checking for chart dependencies. You may need to run `helm dependency build` to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory: jobflow

My opinion at first is to use subchart with the same one command.

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@volcano-sh-bot volcano-sh-bot merged commit a891343 into volcano-sh:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants